(Didn't get a response from an earlier post, this is a repost w/ a rebased patch)
I noticed that the pkey is handled differently between ipoib's create_child and delete_child functions. So a user can create a interface with a pkey, but not delete it with the same pkey. Sort of makes it confusing for the average person. # sys/class/net/ib0 > echo 0x6fff > create_child # /sys/class/net/ib0 > echo 0x6fff > delete_child -bash: echo: write error: No such file or directory # /sys/class/net/ib0 > echo 0xefff > delete_child # /sys/class/net/ib0 > The attached patch simply bitwise-ORs the full membership bit into the delete_child function for consistency. A check for a valid full- membership bit on the create_child function would be fine as well, but IMO this is the lesser confusing option (and is backwards compatible to any scripts people have already written). Al -- Albert Chu [email protected] Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory
0001-Set-the-pkey-full-membership-bit-so-the-input-to-del.patch
Description: application/mbox
_______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
