On Wed, Feb 4, 2009 at 3:55 PM, Sasha Khapyorsky <[email protected]> wrote: > On 14:54 Wed 04 Feb , Hal Rosenstock wrote: >> > >> > (osm_get_node_by_guid()) is expensive operation. If you only need to >> > determine port 0 type - store it as part of struct monitored_node >> > structure. Another (even more universal) approach would be to keep there >> > a reference to related osm_node object. >> >> This was done later in the patch series. > > Good, but why do we need this intermediate version then?
Just as a time saver; it's just the path I took in development. > It would be better to do right things from beginning I think Sure it's better but does it really matter ? > (and also this patch > depends on previous one where redirection table size was changed so I > cannot apply it anyway until things will be clarified or fixed there). I think that position is extreme. I don't think I broke anything that wasn't already broken. Anyhow, if you really want, I'll produce one patch for these changes. -- Hal > Sasha > _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
