> + if ((port_type[i] == MLX4_PORT_TYPE_ETH) ||
> + (port_type[i+1] == MLX4_PORT_TYPE_IB))
seems there is a typo here -- should be && instead of ||. I fixed this
by hand but I'm wondering how much testing this version of the patch
got...
> + dev->caps.supported_type[i] == MLX4_PORT_TYPE_AUTO ? 1
> : 0;
I never understand why people write
(boolean expression) ? 1 : 0;
since the boolean expression is already 1 or 0 anyway. I fixed this.
Anyway, applied, thanks.
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
