On Sun, Apr 12, 2009 at 5:25 AM, Sasha Khapyorsky <[email protected]> wrote: > On 14:39 Tue 24 Mar , Hal Rosenstock wrote: >> > >> > What is a purpose of this? Do you have any plans to use this field? >> > >> > If no, I don't see what this patch adds - SMSL is handled already as part >> > of PortInfo buffer. >> >> It's needed when SMSL is not 0 (e.g. Line's recent patch for lash). > > Ok. I see. Actually the problem is that in do_portinfo() received > PortInfo is not copied to target port's PortInfo (as I thought) and > update is done for only selected fields. > > Wouldn't it be better to rework it in the way where we will not need to > store useless (for simulator) PortInfo values as separate port structure > fields? So incoming PortInfo buffer will be just copied (of course with > caring about special fields - states, RO, etc..).
Perhaps but that seems like a separate cleanup to me. -- Hal > Sasha > _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
