On Tue, Jul 14, 2009 at 2:35 AM, Eli Cohen<e...@dev.mellanox.co.il> wrote:
> On Mon, Jul 13, 2009 at 03:26:06PM -0400, Hal Rosenstock wrote:
>> >
>> > +enum ib_port_link_type ib_get_port_link_type(struct ib_device *device, u8
>> > port_num)
>> > +{
>> > + return device->get_port_link_type ?
>> > + device->get_port_link_type(device, port_num) :
>> > PORT_LINK_IB;
>>
>> So do iWARP devices return PORT_LINK_IB ? If so, that seems a little
>> weird to me.
>>
>> -- Hal
>>
>
> Maybe it's more appropriate to make this function mandatory and
> require all drivers to report the correct port type. What do you
> think?
That seems better to me; another alternative would be to require this
routine for either all iWARP or IB devices as well but that might be
error prone. Maybe someone else has a better idea on this.
-- Hal
_______________________________________________
general mailing list
general@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
