The idea seems sound but checkpatch.pl gives 6 errors for this small patch! Also:
> +static int check_mcast(const u8 *addr,unsigned int addrlen, > + const u8 *broadcast) name of the function could make it clearer what the expected return value is ... eg mcast_addr_is_valid() or something like that. > + if (addrlen != 20) We have INFINIBAND_ALEN defined, seems better than a magic # here. > + if (memcmp(addr,broadcast,6) != 0) Personal taste here, but "if (foo != 0)" always seems silly to me when we could just do "if (foo)" -- haven't looked at what usage of memcmp() is more idiomatic in the kernel tho. - R. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
