[ http://issues.ops4j.org/browse/PAXSB-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829#action_12829 ]
Toni Menzel commented on PAXSB-19: ---------------------------------- Hi Victor, Thanks for submitting this issue and also providing a patch. Usually, it is not a problem to directly change the code in svn. Here at ops4j we practice the "open participation " principle, so no everyone is a committer and is encouraged to use this right. -> no patches ;) To this issue: Actually, i have to say, this is not necessary an issue. You can safely add the inner class via {code} add( Outer.Inner.class ) {code} This is also more aligned to the mantra of this library in my opinion: you really add any type yourself, magic comes when things like bnd calculate manifests but not before. See, there's also no such thing as "addClasses("org.foo.*")" or so, which you could easily imagine. Exactly this, adding a sugar layer on top of this very core will very likely add even your case. So, i will preserve your patch and incorporate your usecase + patch there. Looking forward to your submissions & ideas. cheers, Toni > Adding inner classes to bunlde > ------------------------------ > > Key: PAXSB-19 > URL: http://issues.ops4j.org/browse/PAXSB-19 > Project: Pax Swissbox > Issue Type: Improvement > Components: TinyBundles > Affects Versions: 1.1.0 > Reporter: Victor Antonovich > Assignee: Toni Menzel > Attachments: add_inner_classes.patch > > > Currently TinyBundle paying no attention to inner classes of class added to > bundle using addClass() method. This cause problems, especially for anonymous > inner classes. Attached patch fixes this by looking for inner classes of > class provided to addClass() method and adding them to list of classes to > pack. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.ops4j.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira _______________________________________________ general mailing list general@lists.ops4j.org http://lists.ops4j.org/mailman/listinfo/general