I don't think we should hold the release because some 1.5 code snuck into contrib/regex and contrib/misc.
If this is a real problem for someone they can fix the sources & rebuild? Mike On Wed, Sep 23, 2009 at 6:52 AM, Uwe Schindler <[email protected]> wrote: > Hi, > > I also tested the whole artifacts, works with 1.5. I do not know if it > prevents us from releasing it, but I am the bad guy and started to use Java > 1.4.2 to build and test. Core works perfect, and after removing all contribs > that use -target=1.5 the compilation still fails (there is also the problem > that the build script does not automatically detect your JVM and should > leave the 1.5 contribs unbuild. This would be possible, if we add a ANT > regexp into the contrib-crawl and exclude all contribs which build script > contains "1.5" if java<1.5): > > - db/bdb fails to compile with 1.4 because of a ClassFormatError in one of > the bundled libs, so this contrib is in reality 1.5 only. > - Tests of contrib/misc use String.contains(), which is 1.5 only. As it just > searches for an whitespace, it can be replaced by indexOf(' ')>=0 > - contrib/regex fails to build, because the JavaRegExpCapability defines an > (unused) constant based on the value in Pattern.LITERAL, which does not > exist in 1.4. Removing this constant fixes the problem. > > What should we do? > > ----- > Uwe Schindler > H.-H.-Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: [email protected] > > >> -----Original Message----- >> From: Mark Miller [mailto:[email protected]] >> Sent: Monday, September 21, 2009 7:07 PM >> To: [email protected]; [email protected] >> Subject: [VOTE] Release Lucene 2.9.0 >> >> Okay, lets give this a shot: >> >> The (proposed) release artifacts have been built and are up at: >> >> http://people.apache.org/~markrmiller/staging-area/lucene2.9/ >> >> The changes are here: >> >> http://people.apache.org/~markrmiller/staging-area/lucene2.9changes/ >> >> >> Please vote to officially release these artifacts as 2.9.0, or point out >> any errors and I'll fix and repackage. >> >> We need at least 3 binding (PMC) votes. >> >> Thanks everyone for all their hard work on this! This has been some >> release. >> >> -- >> - Mark >> >> http://www.lucidimagination.com >> >> > > >
