Author: Ivan Mikhnevich
Email: [EMAIL PROTECTED]
Message:
Hi, there.
I've posted a message with topic "Too many open files" a week ago and there are no any
messages about it. It makes me sad. I like your project, but your support and
programming culture is BAD ENOUGH!!!
1) The first problem was in "too many open files" topic. As I've guessed first time,
you forgot to close the TCP socket when connection to host fails (time out). Look at
the line 265 in proto.c (function open_host)... I've found this bug in 20 minutes by
simple reading and text search operation though all your source. I do not understand
why developers did not react to my message. They get money for installing and
supporting their system from clients. It seems that it's senseless to pay them money
for support. Hey, guys, do not loose your clients.
2) Your UdmEscapeURL() function from udmutils.c (line 394) is WRONG. It does not
escapes russian characters. More accurate and precise variant of while statement is
the following one:
for ( ; *s; s++,d++){
if (isalnum(*s)) *d=*s;
else if (*s==' ') *d='+';
else {
sprintf(d,"%%%02X", (unsigned char)*s);
d+=2;
}
}
3) Your HTML parsing is wrong in some cases. For example, they are parsing META-tag
Content-Type/charser and Refresh/URL. Can you imagine that "URL" may be in lower or
mixed cases???
I've repaired a lot of your lines like those (parsehtml.c, line 190):
if(!strcasecmp(tag.name,"refresh")){
if((href=strstr(tag.content,"URL=")))
href+=4;
}else
Right code is:
if(!strcasecmp(tag.name,"refresh")){
if((href=strcasestr(tag.content,"URL=")))
href+=4;
}else
Don't look for strcasecmp in manuals. It's handwritten function. I hope you are able
to write it in 5 minutes.
4) You have some bugs in spelling module when using two different languages. It does
not work properly in some cases of placement Affix and Spell lines in config file.
etc...
Best regards,
Ivan Mikhnevich
Reply: <http://search.mnogo.ru/board/message.php?id=2011>
___________________________________________
If you want to unsubscribe send "unsubscribe general"
to [EMAIL PROTECTED]
