https://issues.apache.org/bugzilla/show_bug.cgi?id=48405
Chris Bowditch <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO --- Comment #2 from Chris Bowditch <[email protected]> 2010-01-07 06:46:22 UTC --- Hi Peter, I've taken a look at your patch and there are a number of checkstyle warnings about the use of tabs and trailing spaces. If you haven't done so already I suggest you enable checkstyle integration with your Java IDE and check the checkstyle report prior to submitting any patches. No need to submit a new patch just for checkstyle as I have corrected the checkstyle warnings locally. However, I am wondering why you have placed only the Interface into commons and put the implementations into FOP? Wouldn't it more make sense to put the implementations into commons too. I see they have a dependency on the ColorUtil.toCMYKGrayColor method in FOP, but that could be moved to a super class of ColorUtil that lives in commons. The move should be easy enough as your converter class appears to be the only user of that method. Chris -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
