https://issues.apache.org/bugzilla/show_bug.cgi?id=49703
--- Comment #3 from Glenn Adams <gl...@skynav.com> 2010-08-18 05:43:59 EDT --- Overall I was attempting to remove the deprecation warnings in FOP deriving from TextHandler#drawString. See inline below for specific answers. (In reply to comment #2) > A few questions: > > In the existing situation TextHandler deprecates registering a > Graphics2D object with the TextHandler object. Instead, the > recommended way is to give the Graphics2D object with the drawString > method. Why do you restore registering a Graphics2D object in its full > glory (remove deprecation, new method getGraphics)? The prior deprecation of the drawString method appeared to be an incomplete solution. In particular, StrokedTextHandler.java provided an implementation that continued to use a local reference to the G2D instance. > The PSTextHandlerAdapter is not used. Why do you introduce it? > > There are now an interface PSTextHandler and a class > PSTextHandlerAdapter which does not implement that interface. The > names are confusing. I introduced it as a counterpart to the more generic TextHandlerAdapter in order to allow clients of the commons library to not encounter deprecation reports due to their use of PSTextHandler. However, I see I mistakenly had PSTextHandlerAdapter implementing TextHandler rather than PSTextHandler, which was my intent. Generally speaking, with TextHandlerAdapter PSTextHandlerAdapter I was trying to hide the deprecation of #drawString(String...) in external clients since the adapters provided an adequate solution. Having said that, I am open to other solutions, such as leaving the original deprecation in place, but with a time schedule or specific release target for its removal. G. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@xmlgraphics.apache.org For additional commands, e-mail: general-h...@xmlgraphics.apache.org
