Mihai - Thanks for this patch and for the fixes in your other email. Give me a bit of time to work through them. I'll try to spend some time on them next week.
After a quick peek, these look like valuable fixes and extensions. And, thank you for pushing on creating unit tests. I *really* need that. Have a enjoyable weekend. - Dave -- Dave Kuhlman http://www.rexx.com/~dkuhlman ----- Original Message ---- > From: Mihai Ibanescu > Sent: Thursday, August 27, 2009 2:54:14 PM > > Following up on my own email. > > Attached is a test case for the valueof problem. > > Without the patch, this is how the subclass looks like: > > class childSub(supermod.child): > def __init__(self, name=None, valueOf_=''): > supermod.child.__init__(self, name) > supermod.child.subclass = childSub > # end class childSub > > so valueOf_ is not passed to the parent class when one creates a node by hand. > > Dave, do you find this approach of writing tests something you're > comfortable accepting? > > Thanks! > Mihai > > > On Thu, Aug 27, 2009 at 5:21 PM, Mihai Ibanescuwrote: > > Dave, thanks for incorporating the patches in 1.18d. > > Here's another set :-) > > > > groups.patch and groups-tests.patch both deal with the same problem (I > > didn't merge them because I had them in different commits in > > mercurial). They are about xs:group structures. group-tests.patch > > verifies groups are properly expanded. > > > > valueOf_.patch will pass in the value of the node's text to the > > superclass (it was not). I hope I can write a test for this, since it > > seems like something we don't want regressions for. > > > > no-dates.patch adds a command-line option, --no-dates, that will > > prevent generateDS from putting the timestamp inside the generated .py > > files. This is helpful for cases where you don't want your only > > changes to be date changes. > > > > Thanks! > > Mihai > > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ generateds-users mailing list generateds-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/generateds-users
