George, No, not yet. I did the pull from your code. I'll look into testing and commiting and pushing when I get back. But, so far, there is just that one small change (initializing catalogFilename). So, if you add that one line, then you've got what I'm testing with.
Now, got to get a few last things into the car before I off ... Dave -- Dave Kuhlman http://www.rexx.com/~dkuhlman >________________________________ > From: George David <geo...@miamisalsa.com> >To: Dave Kuhlman <dkuhl...@pacbell.net> >Cc: "generateds-users@lists.sourceforge.net" ><generateds-users@lists.sourceforge.net> >Sent: Tuesday, July 30, 2013 8:04 AM >Subject: Re: [Generateds-users] XML Catalog file support > > > >Thanks Dave! Have you committed the your fixes to my code? I don't see the >changes nor any new commits. > > > >On Mon, Jul 29, 2013 at 10:57 PM, Dave Kuhlman <dkuhl...@pacbell.net> wrote: > >George, >> >>Thanks for this enhancement. I've included your changes in >>my code base. So far, my tests of your changes look good. >>I've created a unit test for the use of the catalog flag. And, >>then I need to do some more testing. >> >>By the way, I did have to make a 1-line change to your code. >>I got an error, when I omitted the -c command line option, >>I believe. Here is a diff: >> >># ================================================ >> >>--- generateDS.py 2013-07-29 12:28:02.298974517 -0700 >>+++ ../../../generateDS.py 2013-07-29 12:43:25.138979406 -0700 >>@@ -5675,7 +5675,8 @@ >> import process_includes >> outfile = StringIO.StringIO() >> process_includes.process_include_files( >>- infile, outfile, inpath=xschemaFileName, >>catalogpath=catalogFilename) >>+ infile, outfile, inpath=xschemaFileName, >>+ catalogpath=catalogFilename) >> outfile.seek(0) >> infile = outfile >> parser.parse(infile) >>@@ -5825,6 +5826,7 @@ >> NoQuestions = False >> showVersion = False >> xschemaFileName = None >>+ catalogFilename = None >> for option in options: >> if option[0] == '--session': >> sessionFilename = option[1] >># ================================================ >> >> >>The first change above is just so that the line is less than 81 characters. >> >>Thanks again. >> >> >>Dave >> >> >>-- >> >> >>Dave Kuhlman >>http://www.rexx.com/~dkuhlman >> >> >>>________________________________ >>> From: George David >>>To: Dave Kuhlman <dkuhl...@pacbell.net> >>>Cc: "generateds-users@lists.sourceforge.net" >>><generateds-users@lists.sourceforge.net> >>>Sent: Friday, July 26, 2013 4:38 PM >>>Subject: Re: [Generateds-users] XML Catalog file support >> >>> >>> >>> >>>Thanks! I went the BitBucket route. I tried to keep with the coding >>>guidelines I saw in the code. Hopefully it won't need to change much. >>> >>> >>> >>>On Fri, Jul 26, 2013 at 4:06 PM, Dave Kuhlman <dkuhl...@pacbell.net> wrote: >>> >>>> From: George David >>>> >>>>>To: generateds-users@lists.sourceforge.net >>>>>Sent: Wednesday, July 24, 2013 2:46 PM >>>>>Subject: [Generateds-users] XML Catalog file support >>>> >>>>> >>>>>I've modified version 2.10a to support loading schema locations from an >>>>>XML catalog. How do I submit this change? >>>>> >>>>> >>>>>Thanks, >>>>>George >>>> >>>> >>>>George - >>>> >>>>Terrific. >>>> >>>>One way to submit a change would be to clone the repository at Bitbucket, >>>>make >>>>your changes to that clone, then submit a pull request to me. You will need >>>>Mercurial if you are going to do it this way. >>>> >>>> >>>>Another way would be to take version 2.10b (the latest), make your changes >>>>to that, >>>>then do a diff between the original and your changes, and send me the diff >>>>file. So, >>>>suppose all your changes are in generateDS.py, then you'd run this: >>>> >>>> >>>> $ diff -u generateDS.py.orig generateDS.py >>>> >>>>and send me the result. >>>> >>>>Or, if you make your changes to the version 2.10b of generateDS.py, you >>>>could >>>>just send me that changed file, or whatever other file you changed, and I >>>>can do >>>>the diff myself. >>>> >>>>Looking forward to seeing your changes. And, thanks for the help. >>>> >>>> >>>>- Dave >>>> >>>> >>>> >>>> >>>> >>>>-- >>>> >>>> >>>>Dave Kuhlman >>>>http://www.rexx.com/~dkuhlman >>>> >>> >>> >>> >> > >------------------------------------------------------------------------------ >Get your SQL database under version control now! >Version control is standard for application code, but databases havent >caught up. So what steps can you take to put your SQL databases under >version control? Why should you start doing it? Read more to find out. >http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk >_______________________________________________ >generateds-users mailing list >generateds-users@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/generateds-users > > > ------------------------------------------------------------------------------ Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk _______________________________________________ generateds-users mailing list generateds-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/generateds-users
