On Fri 27 Sep 2013 09:06:38 PM PDT, George David wrote: > Hi Dave, > > I merged in all the changes that happened since I synced up last and fixed > all the unit test that I could. There are two remaining unit test that are > failing because two files are missing: catalogtest.xsd and > simpletypes_other1_sub.py >
George, I responded to the pull request, and now I have your changes. I've merged them with a few minor additions of my own. I've also made some cosmetic changes. I use the flake8 style checker, and almost all of my changes had to do with removing white space at the end of lines. This new version (with your changes) now passes unit tests. Looks good. If you have any more changes, please send me another pull request. If not, then let me know and I'll push my version to my Bitbucket repository. Then we can work on a unit test for your new capability. I'd actually like to do that, because writing a unit test would force me to learn more about this new feature. And, thanks again for all your work on this new feature. Dave > > On Fri, Sep 27, 2013 at 6:24 PM, George David <geo...@miamisalsa.com> wrote: > >> Hi Dave, >> >> I fixed the failUnlessEquals and did some more cleanup. I notice I need to >> merge but BitBucket won't merge because of conflicts. I'll need to figure >> out how to manually merge. >> >> I still have one last test failing, test_018... >> >> I notice this among others is also failing on your unreleased code. >> >> I'll look into adding some unit tests. I'm happy to help with docs and >> more unit testing. >> >> Thanks, >> George >> >> >> >> On Fri, Sep 27, 2013 at 2:31 PM, Dave Kuhlman <dkuhl...@pacbell.net>wrote: >> >>> George, >>> >>> >>> I'm having trouble sending you an email. I believe it's because of my >>> >>> email service. So, I'm sending this from a different account. >>> >>> >>> You can read my message at the generate-users email list, if you have >>> >>> not already. >>> >>> >>> Thanks again for help. >>> >>> >>> Dave >>> >>> >>> -- >>> >>> >>> Dave Kuhlman >>> http://www.davekuhlman.org >>> >> >> > -- Dave Kuhlman http://www.davekuhlman.org ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ generateds-users mailing list generateds-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/generateds-users
