Alim, I've merged your pull request at Bitbucket.
I've made a few minor changes: - I had to fix a line or two so that generateDS.py will run under Python 3. - I use the flake8 syntax and style checker (https://pypi.python.org/pypi/flake8). I made a few changes so that flake8 pep8 style checking is happy. Specifically, I shortened some lines so that they would be within the 80 length recommendation. By the way, I recommend flake8, if you do not use it already, although I have no opinion about how flake8 and pylint compare. I've tried to make the code in the generateDS project conform to flake8 checking, so, for example, generateDS.py, process_includes.py, etc have pass, *but* the code generated by generateDS.py does not. I'll do some more testing, and I'll see about adding a few things to the documentation. Then I'll push my changes back to Bitbucket in a a few days. I'm still trying to understand some of the details of your changes It will take me a little time. Again, thanks so much for these enhancements. Dave On Tue, Jun 20, 2017 at 10:09:38AM -0000, Alim Gokkaya wrote: > --- you can reply above this line --- > > New comment on pull request: > > https://bitbucket.org/dkuhlman/generateds/pull-requests/25/various-improvements-and-fixes#comment-39160310 > > Alim Gokkaya said: > > I've locally tested the new options as well and they look stable, > so you can proceed with merging. > > I've just added descriptions into the usage string for the new > options as well. > > Thanks > > -- > > Unsubscribe from pull request emails for this repository. > https://bitbucket.org/dkuhlman/generateds/pull-requests/25/unsubscribe/dkuhlman/a933d3731f95c2547b534cc20612be2d3e0b2bbe/ -- Dave Kuhlman http://www.davekuhlman.org ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ generateds-users mailing list generateds-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/generateds-users
