Daniel, Thanks for this report.
I made a patch. See attached diff file. Or, you can get new code at Bitbucket: https://bitbucket.org/dkuhlman/generateds By making the change where .getName is called rather than changing its definition, we leave getName as a simple getter-function. That seems preferable, even though I don't know why I feel that way. Does this work for you? I also did some debugging (using pdb/ipdb, setting a breakpoint in getName, and then using backtrace). As far as I can tell, the location you identified (and where I've made my patch), is the only place it's called. Will this work for you? Thanks for the comment about your use of generateDS. Hope it's useful and helpful for you. And, thank you for tracking this problem down and for suggesting a fix. That was very helpful. Dave On Thu, Aug 02, 2018 at 08:48:38AM +0000, Ramirez, Daniel - FAS GmbH wrote: > Hi Mr. Kuhlman, > > First of all, cool piece of software here. We are planning to use > it in a project about automotive industry and it could save us a > lot of time and effort, so kudos! > > While generating some bindings for a huge XSD file I got > validation errors on the generated code because of classes names. > It looked as if the cleanup list parameter was not being used. I > debugged it using the packaged source code and I narrowed it to > generateSimpleTypes.writeEnumClass . Here, the output is generated > by calling the simpleType.getName() and it looks like here is the > problem. > > As it outputs directly the imported name, no cleanup takes place. > I edited our SimpleTypeElement.getName() method so it returns a > cleanupName(self.name) but I am not sure that this will not break > other internal references; that is why I decided to notify the bug > instead of doing a PR. > > This seemed to fix the problem in our case so, if it is a generic > enough solution, I can submit the PR. Let me know what suits you > best. > > Thanks again and best regards, > > Daniel Ramirez > Software Development > FAS GmbH > Frühlingstraße 31-33 - 85055 Ingolstadt > Mobil: +49-(0) 152-21700-621 > Email: > daniel.rami...@fahrerassistenzsysteme.de<mailto:daniel.rami...@fahrerassistenzsysteme.de> -- Dave Kuhlman http://www.davekuhlman.org ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ generateds-users mailing list generateds-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/generateds-users
