Hello Lonnie,

you revealed a subtle bug in our library make files for virtualbox,
which only emerges when doing non-parallel builds. Could you please
give the attached patch a try - it worked for me pretty well and is on
its way to origin/staging.

Happy hacking
-- 
Christian Helmuth
Genode Labs

http://www.genode-labs.com/ · http://genode.org/
https://twitter.com/GenodeLabs · /ˈdʒiː.nəʊd/

Genode Labs GmbH · Amtsgericht Dresden · HRB 28424 · Sitz Dresden
Geschäftsführer: Dr.-Ing. Norman Feske, Christian Helmuth
commit d621ad22baffe5e692483761967a2c7819539fe1 (HEAD, origin/staging, staging)
Author: Christian Helmuth <[email protected]>
Date:   Wed Mar 5 17:05:44 2014 +0100

    vbox: fix dependencies of generated files
    
    Express that the target binary files depend on the generated files not
    the source files. The old expression seems to confuse Make, which then
    logs a bogus error like the following
    
          COMPILE  Runtime/common/err/errmsg.o
      genode-x86-g++: error: Runtime/common/err/errmsg.cpp: No such file or directory
      genode-x86-g++: fatal error: no input files
      compilation terminated.
      make[2]: *** [Runtime/common/err/errmsg.o] Error 1
      make[1]: *** [virtualbox-runtime.lib] Error 2
---
 ports/lib/mk/virtualbox-devices.mk | 4 ++--
 ports/lib/mk/virtualbox-runtime.mk | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/ports/lib/mk/virtualbox-devices.mk b/ports/lib/mk/virtualbox-devices.mk
index b9b7c29..4418264 100644
--- a/ports/lib/mk/virtualbox-devices.mk
+++ b/ports/lib/mk/virtualbox-devices.mk
@@ -44,7 +44,7 @@ CC_WARN += -Wno-unused-but-set-variable
 #
 CC_OPT += -DVBOX_WITH_HGSMI -DVBOX_WITH_WDDM -DVBOX_WITH_VDMA
 
-Devices/Graphics/DevVGA.cpp: vbetables.h
+Devices/Graphics/DevVGA.o: vbetables.h
 
 vbetables.h: vbetables-gen
 	$(MSG_CONVERT)$@
@@ -56,7 +56,7 @@ vbetables-gen: Devices/Graphics/BIOS/vbetables-gen.c
 
 
 
-Devices/PC/ACPI/VBoxAcpi.cpp: vboxaml.hex vboxssdt-standard.hex vboxssdt-cpuhotplug.hex
+Devices/PC/ACPI/VBoxAcpi.o: vboxaml.hex vboxssdt-standard.hex vboxssdt-cpuhotplug.hex
 
 vboxaml.hex: vbox.dsl
 	iasl -tc -vs -p $@ $^
diff --git a/ports/lib/mk/virtualbox-runtime.mk b/ports/lib/mk/virtualbox-runtime.mk
index 492dbd6..9b25086 100644
--- a/ports/lib/mk/virtualbox-runtime.mk
+++ b/ports/lib/mk/virtualbox-runtime.mk
@@ -111,7 +111,8 @@ SRC_S  += Runtime/common/asm/ASMAtomicUoReadU64.as
 SRC_S  += Runtime/common/asm/ASMAtomicXchgU64.asm
 
 SRC_CC += Runtime/common/err/errmsg.cpp
-Runtime/common/err/errmsg.cpp: errmsgdata.h
+Runtime/common/err/errmsg.o: errmsgdata.h
+
 errmsgdata.h: $(VIRTUALBOX_DIR)/include/iprt/err.h \
               $(VIRTUALBOX_DIR)/include/VBox/err.h
 	$(MSG_CONVERT)$@
------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
_______________________________________________
Genode-main mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/genode-main

Reply via email to