On 2/24/07, Boyd Stephen Smith Jr. <[EMAIL PROTECTED]> wrote:
On Saturday 24 February 2007 00:49, Daiajo Tibdixious wrote: [snip: good info re: making a dependency optional] Also, make that, when the use flag is disabled, the package refuses to link against xprintproto. Otherwise, you can have a situation where xprintproto is unmerged by --depclean, but xdpyinfo is using it dispite the -xprint USE flag. E.g. xprintproto is merged as a dependency of X xdpyinfo is merged (-xprint), but finds the appropriate header and links against xprintproto. X is removed. emerge --depclean thinks it can remove xprintproto, since xdpyinfo doesn't depend on it, despite being linked against it.
Okay, I don't understand enough about how USE flags modify compilation. e.g. x11-apps/xdpyinfo xdpyinfo.c (the only source file) has #ifdef INCLUDE_XPRINT_SUPPORT #include <X11/extensions/Print.h> #endif /* INCLUDE_XPRINT_SUPPORT */ yet this is defined by # if HAVE_X11_EXTENSIONS_PRINT_H # define INCLUDE_XPRINT_SUPPORT # endif earlier in the program. It may be because xdpyinfo doesn't have proper xprint conditionality that it wasn't made conditional in the ebuild. Anyway good point with depclean, I have 2 other packages depending on printproto: x11-libs/libXp-1.0.0 XpNotifyPdm.c uses printproto, and its not conditional x11-libs/openmotif uses printproto in 3 includes, unconditionally so the change to xdpyinfo doesn't get rid of printproto.
If the package comes with a testsuite, make sure to run that against both the old and new versions and hopefully you get similar results.
Not that I can see, I'll remember.
*DO* give your emerge --info, although it may not seem relevant. *DO* make the bug as a feature request, and set it's priority appropriately.
Yeah, I'll include the source code snippets to. xdpyinfo has some other dependencies, I'm going to check them as well, just for 'fun'. :) Actually xdpyinfo also depends on libXp and that explains why printproto is unconditional, I would have to go through it, and any others, and make printing optional on xprint. Hmm, I might shelve this until I understand how USE flags work, as I have no idea how to implement conditionality with USE/configure. -- [email protected] mailing list
