On Mon, Jun 27, 2011 at 2:18 PM, Sebastian Pipping <[email protected]> wrote: >> This is certainly not the case. Let me be clear, mistakes in the >> current code come from having the same CFLAG, CHOST, etc strings >> duplicated in many places. Refactoring the code would allow us to >> catch mistakes like >> http://git.overlays.gentoo.org/gitweb/?p=proj/catalyst.git;a=commit;h=db4323146ce27362948de6eab57e1dbe28240bde >> much more quickly. >> >> It seems to me that test coverage would be much simpler if the classes >> were refactored, since various combinations would use nearly identical >> code paths. > > It would make some code pathes being taken more often but still leave > the "leafes" ontouched without a test for each leaf. Right? > > What could work though is a throw-away test for refactoring only, say > writing a piece of code making a text file listing all combination of > CFLAGS offered from targets. If after the refactoring you get the very > same text file out, that's a good indicator. Is the idea clear?
Yep, that should work and wouldn't be very much work. That seems like a good idea. Thanks! Matt
