On Sat, Dec 14, 2013 at 03:15:42AM -0800, Brian Dolbec wrote: > On Fri, 2013-12-13 at 21:08 -0800, Matt Turner wrote: > > On Fri, Dec 13, 2013 at 7:07 PM, Brian Dolbec <[email protected]> wrote: > > > Migrate more hardcoded paths to use settings variables instead. > > > > I can't really make any sense of the commit title, > > This is the full commit message in git: > > Remove self.mounts and self.mountmap's use of paths for keys and paths. > > Migrate more hardcoded paths to use settings variables instead. > --------------- > > git send-email broke it up, using the first line as the subject, the > other lines are included in the main text body.
`git log --oneline` will also only use the first line of the commit message, so it's nice to have it make sense. I don't think the current version reads too badly, but perhaps: Don't use paths as mountmap keys would cover it more succinctly? > > and it'd be preferable to do one path per patch. > > Re-coding that mounts and mountmap mess was hard enough and required > lots of testing, fixing to get it correct and working. Splitting it > up even more is an exercise in futility. I'm playing around with this now ;). We'll see if I can get the commits reshuffled and preserve the same tree hash as Brian's a1f054e [1]. Cheers, Trevor [1]: http://git.overlays.gentoo.org/gitweb/?p=proj/catalyst.git;a=commit;h=a1f054e5efaec3877a964e6a72410b5bbee9c03b -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
