On Wed, 2013-12-18 at 22:39 -0800, W. Trevor King wrote: > On Wed, Dec 18, 2013 at 09:18:06PM -0800, [email protected] wrote: > > @@ -116,12 +115,13 @@ def parse_config(myconfig): > > print "Setting",x,"to default value > > \""+confdefaults[x]+"\"" > > conf_values[x]=confdefaults[x] > > > > + options = conf_values["options"].split() > > # parse out the rest of the options from the config file > > - if "autoresume" in string.split(conf_values["options"]): > > + if "autoresume" in options: > > print "Autoresuming support enabled." > > conf_values["AUTORESUME"]="1" > > > > - if "bindist" in string.split(conf_values["options"]): > > + if "bindist" in options: > > print "Binary redistribution enabled" > > conf_values["BINDIST"]="1" > > else: > > These changes look fine to me, but I'd rather just convert to the > stdlib's ConfigParser. That's going to blow away this whole function, > so I don't see the point in fixing it up now. Of course, if the > powers that be think a ConfigParser conversion is in the far-distant > future, then I'm ok with this as a temporary cleanup. > > Cheers, > Trevor >
There's more, I have a commit in the rewrite that removes the duplication of options and the resulting standalone boolean variables. Instead, I turn options into a set which eliminates the possibility of duplicate entries, plus inclusion automatically implies a True value, absence a False value. So even if this was merged, it'd be wiped away soon anyway.
signature.asc
Description: This is a digitally signed message part
