On Sun, Mar 02, 2014 at 03:07:03PM -0800, Brian Dolbec wrote: > Make testpath automagic via dwfeed's tweak > Update HOWTO on how to run the git checkout code directly without > being installed.
I think this patch is a bit excessive, since I don't expect people to
be running catalyst before they could understand something like:
To run from the live checkout, use:
PYTHONPATH=. ./bin/catalyst -c catalyst.conf -f path/to/your.spec
But if folks want a script to set that up for them, I won't complain
;).
> + # source ./testpath
> + # catalyst -c catalyst.conf -f path/to/your.spec
You use the versioned catalyst.conf file here, but…
> +# catalyst -c ./test.conf -p -f stage1.spec
… suggest 'test.conf' here. I think you should use catalyst.conf for
both, and leave it up to users to realize that they can have multiple,
non-overlapping configurations.
Also, there are two spaces after the '-p' ;).
> +export PATH="$(dirname $BASH_SOURCE[0])/bin:${PATH}"
> +
> +export PYTHONPATH="$(dirname $BASH_SOURCE[0]):${PYTHONPATH}"
I think you need braces around BASH_SOURCE[0]:
$ cat test.sh
echo "'${0}'"
echo "'${BASH_SOURCE[0]}'"
echo "'$BASH_SOURCE[0]'"
$ source test.sh
'bash'
'test.sh'
'test.sh[0]'
For extra elegance (to avoid a trailing colon if PYTHONPATH was
originally null or unset):
export PYTHONPATH="$(dirname ${BASH_SOURCE[0]})${PYTHONPATH:+:}${PYTHONPATH}"
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
