On Mon,  5 Oct 2015 23:48:07 -0400
Mike Frysinger <[email protected]> wrote:

> This is a member function of a class, so it must have a |self|
> argument first.  The current code is clearly broken otherwise.  Not
> that it seems to matter as there aren't any callers in the current
> codebase. ---
>  catalyst/lock.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/catalyst/lock.py b/catalyst/lock.py
> index a6f9d3a..9f954eb 100644
> --- a/catalyst/lock.py
> +++ b/catalyst/lock.py
> @@ -354,7 +354,7 @@ class LockDir:
>                               return True
>               return False
>  
> -     def hardlink_active(lock):
> +     def hardlink_active(self, lock):
>               if not os.path.exists(lock):
>                       return False
>
  
:)

If you want to re-do all the lock code, go for it.  I know Anthony was
looking at putting that on to his TODO list.  Maybe the two of you can
get it all in great shape.

-- 
Brian Dolbec <dolsen>


Reply via email to