On Thu, 8 Oct 2015 20:38:25 -0400 Mike Frysinger <[email protected]> wrote:
> how do people feel about killing off the use of "print" everywhere and > moving to the standard logging module ? biggest advantages in my > mind: > - we get much easier control over where the output goes > (file/stdout/...) > - we force people to select a level (info/warning/error) > - we get standardized output > - we can more easily control the output (debug/verbose/etc...) > - we can include module/func/line info transparently in debug modes > - we can exit transparently on fatal/critical messages (rather than > using die/exit/etc... directly) > - we can colorize warnings/errors transparently > - we get py3 compat for free (all current print usage is py2-only) > -mike It's been on our wish list for several years. So go for it! That'll be one less thing holding up p3 compatibility. I've added some extra print statements in there doing the re-write, but there was just too much in there that needed fixing. One thing that is needed more than that still is: There are still some hard coded paths. I believe they are only in the bash support scripts. I should have all of the python side changed over. All exported variables from python to bash are prefixed with clst_ and dashes and slashes are replaced with "_" if they are in the variable name. We are not able to relocate the main gentoo tree until those are fixed. It was how I got started re-writing catalyst in the first place. Then on the python side paths were hard coded EVERYWHERE and used as both a variable name and value. -- Brian Dolbec <dolsen>
pgpdcCMoxH0LM.pgp
Description: OpenPGP digital signature
