On 16 Dec 2015 11:41, Kevin Zhao wrote:
> - run_mkisofs -r -U -chrp-boot -netatalk -hfs -probe -map
> "${clst_target_path}"/boot/map.hfs -part -no-desktop -hfs-volid
> "${clst_iso_volume_id}" -hfs-bless "${clst_target_path}"/boot -hide-hfs
> "zisofs" -hide-hfs "stages" -hide-hfs "distfiles" -hide-hfs "snapshots" -J
> ${mkisofs_zisofs_opts} -V "${clst_iso_volume_id}" -o "${1}"
> "${clst_target_path}"/
> + if [ "${clst_subarch}" == "ppc64le" ]||[ "${clst_subarch}" ==
> "power8" ]
please put spaces around the || operator, and use = instead of ==
isn't this power8 specific ? so do you really need to look at ppc64le ?
> + then
> + run_mkisofs -v -r -T -U -l -cache-inodes -chrp-boot -V
> "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"
> + else
> + run_mkisofs -r -U -chrp-boot -netatalk -hfs -probe -map
> "${clst_target_path}"/boot/map.hfs -part -no-desktop -hfs-volid
> "${clst_iso_volume_id}" -hfs-bless "${clst_target_path}"/boot -hide-hfs
> "zisofs" -hide-hfs "stages" -hide-hfs "distfiles" -hide-hfs "snapshots" -J
> ${mkisofs_zisofs_opts} -V "${clst_iso_volume_id}" -o "${1}"
> "${clst_target_path}"/
> + fi
i know the existing code is ugly, but please fix that here. rather than
duplicate the huge command line, factor out the common bits. something
like:
flags=( -r -U )
if [ "${clst_subarch}" = "power8" ]
then
flags+=(
-v -T -l -cache-inodes -chrp-boot
)
else
flags+=(
...
)
fi
run_mkisofs "${flags[@]}" \
-J ${mkisofs_zisofs_opts}
-V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"
also, it seems like some of the flags you dropped for power8 should stay there.
-mike
signature.asc
Description: Digital signature
