On Sat, 2 May 2020 16:18:43 -0700 Matt Turner <[email protected]> wrote:
> On Sat, May 2, 2020 at 4:03 PM Brian Dolbec <[email protected]> wrote: > > > > On Fri, 1 May 2020 18:40:31 -0700 > > Matt Turner <[email protected]> wrote: > > > > > Signed-off-by: Matt Turner <[email protected]> > > > --- > > > > Again, no reasoning > > Sorry. I think it's pretty apparent. > > Simple functions that are called only from a single place and exist in > a different file should just be inlined. > > Should I just add that to the commit message? > No, like I commented in patch #6, list what was inlined. Was a poor choice of words on my part. The way your commit message are, you have to have the commits open in gitg or gitweb log view, or git log yyyyyyyyy to see the changes to know what was changed, or why. It is about readability. eg: # git log ... commit yyyyyyyyyyyyyyyyyyyyyyyyyyyyy Author: Matt Turner <[email protected]> Date: Tue Apr 22 17:57:34 2020 -0700 targets: Inline functions with one caller commit xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx Author: Matt Turner <[email protected]> Date: Tue Apr 21 17:57:34 2020 -0700 targets: Inline filesystem-functions.sh commit wwwwwwwwwwwwwwwwwwwwwwwwwwwwww Author: Matt Turner <[email protected]> Date: Tue Apr 21 17:57:34 2020 -0700 targets: Drop most fstypes ================================================================== Better is ================================================================== commit yyyyyyyyyyyyyyyyyyyyyyyyyyyyy Author: Matt Turner <[email protected]> Date: Tue Apr 22 17:57:34 2020 -0700 targets: Inline functions with one caller check_bootargs, check_filesystem_type were only used in bootloader_setup.sh commit xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx Author: Matt Turner <[email protected]> Date: Tue Apr 21 17:57:34 2020 -0700 targets: Inline filesystem-functions.sh create_squashfs, create_jffs2 were only used in target_image_setup.sh commit wwwwwwwwwwwwwwwwwwwwwwwwwwwwww Author: Matt Turner <[email protected]> Date: Tue Apr 21 17:57:34 2020 -0700 targets: Drop most fstypes drop ziofs, normal, noloop filesystem types They are old/obsolete/ no longer relavent...
