On Sat, Oct 17, 2020 at 12:00 PM Felix Bier
<[email protected]> wrote:
>
> This commit fixes the following issues:
>
>   * The PORTDIR_OVERLAY variable has been deprecated by Gentoo.
>
>     With this commit, the variable is no longer written to the
>     generated make.conf. Instead, a config file
>     /etc/portage/repos.conf/<repo-name>.conf
>     is generated for each overlay. The repo name is read from the
>     overlay using the portage API. Internally, portage parses
>     metadata/layout.conf and profiles/repo_name to obtain the name.
>
>     References:
>     https://wiki.gentoo.org/wiki//etc/portage/make.conf
>     https://wiki.gentoo.org/wiki//etc/portage/repos.conf
>
>   * All overlays were copied into the same target directory. If the
>     same file name occurred in multiple overlays, the last overlay
>     would overwrite all previous files with this name. In particular,
>     only the metadata/layout.conf of the last overlay was retained,
>     so it was not possible to reference the other overlays e.g. via
>     the masters entry in the layout.conf or the portage-2 syntax
>     for specifying a parent profile from another overlay. Also,
>     this created problems when the overlays contained ebuilds
>     for the same package, but with differing versions, because
>     after copying, the target directory contained both versions of the
>     ebuild but only the manifest file of the last overlay.
>
>     With this commit, each overlay is copied into a separate
>     sub-directory, e.g. /var/gentoo/repos/local/<repo-name>/.
>     This directory is referenced via the location entry in the
>     generated /etc/portage/repos.conf/<repo-name>.conf.
> ---

Hello,

Thank you for the patches. I'm happy to see them.

I cannot apply the patches however. This one in particular is badly
line wrapped by your mail client. I tried fixing it up, but either
failed or don't know what this is supposed to apply to.

It looks like the intention is for this to apply to the
catalyst-3.0-stable branch since it discusses copying overlays into a
subdirectory, rather than any mention of squashfs snapshots.

I really don't want new feature work on the catalyst-3.0-stable
branch, for example. If that is the target, then please consider
rebasing the work onto the master branch.

Matt

Reply via email to