On Fri, Oct 23, 2020 at 10:01 AM Daniel Cordero <gentoo.catal...@xxoo.ws> wrote:
>
> On Fri, Oct 23, 2020 at 09:25:29AM -0700, Matt Turner wrote:
> > On Fri, Oct 23, 2020 at 2:19 AM Daniel Cordero <gentoo.catal...@xxoo.ws>
> > wrote:
> > >
> > > From: Daniel Cordero <catal...@0xdc.io>
> > >
> > > Previous syslinux based CDs had this information.
> > > Necessary for direct kernel booting with virt-install --location.
> > >
> > > Fixes: 0a27a7a39a "targets: Use GRUB for BIOS boot"
> > >
> > > Signed-off-by: Daniel Cordero <catal...@0xdc.io>
> > > ---
> > > targets/support/create-iso.sh | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh
> > > index 9b1c7185..b11b046f 100755
> > > --- a/targets/support/create-iso.sh
> > > +++ b/targets/support/create-iso.sh
> > > @@ -192,6 +192,7 @@ case ${clst_hostarch} in
> > > isoroot_checksum
> > >
> > > case ${clst_hostarch} in
> > > + amd64|x86) extra_opts="-joliet" ;;
> >
> > Is there any reason to limit this to amd64/x86?
> >
>
> My concern is that the other arches may not have had this information on
> their ISOs. I do not know if those arches might not like it.
Oh, I see: this flag is passed through grub-mkrescue to mkisofs. I
guess this is an alias for the -J flag to mkisofs? Strange that I
don't see it documented in either mkisofs(8) or grub-mkrescue(1). It
looks like we're passing -J to mkisofs/xorriso on alpha and hppa, so
my feeling is that we should just use it on all platforms. I'm happy
to adjust the patch when I commit it.
