Am Samstag, dem 27.02.2021 um 13:52 -0500 schrieb Matt Turner: > On Thu, Feb 25, 2021 at 8:09 AM Daniel Cordero > <gentoo.catal...@xxoo.ws> wrote: > > > > From: Daniel Cordero <catal...@0xdc.io> > > > > This fixes commit a500400592aaa309 > > Felix also mentioned on IRC that he wanted this functionality. > > <felixb> | mattst88_: Ok thank you for the information. I will look > into the profile problem after I'm done with the PORTDIR removal > patches. So guess the right approach would be to restore the eselect > call in some form, improving the documentation and possibly ensuring > that eselect is only called once. I think it would also make sense to > remove the manual symlink logic in config_profile_link, since that > would be redundant with eselect and is more limited (i.e. it > <felixb> | would take some work to adapt the manual symlinking to > deal > with profiles outside of the main repo and parsing profile names such > as myrepo:myprofile, which eselect can resolve). > > So, cc'ing him to see what he thinks.
Hi, I'm happy with how Daniel solved this. I was worried about the maintenance cost of duplicating eselect functionality, but this is very compact. I assumed that eselect would resolve profile names without repo: prefix by looping over all repos to find a matching profile, but after analysing eselect it seems such profile names are expected to always be in the main repo. So using eselect would give no addtional functionality compared to this patch. I did not find any helper functions in the portage library for handling this task. Possibly we could improve error reporting (failing early if the link is broken, instead of waiting for emerge to fail later), but I'm fine with this being done in a separate step. Best regards, Felix
