[gentoo-commits] proj/kde:master commit in: eclass/

[Andreas Sturmlechner]

commit:     f339ee5843ba31255239bce871c470cfef590bee
Author:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Sat May 17 17:09:31 2025 +0000
Commit:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Tue May 20 20:51:45 2025 +0000
URL:        https://gitweb.gentoo.org/proj/kde.git/commit/?id=f339ee58

cmake.eclass: Add recursive CMakeLists.txt unsupported version detection

We need to ramp up detection of unsupported CMake build systems with
CMake 4. This will detect CMakeLists.txt files setting insufficient
cmake_minimum_required VERSION level even in project subdirectories,
putting out appropriate eqawarn message about the need to fix ${PN}.

That makes us not rely on tinderbox runs w/ unmasked cmake-4 slowly
being able to build everything up to leaf packages, and also helps
detect insufficient subproject minimums that could otherwise be masked
by USE flag choice.

Bug: https://bugs.gentoo.org/951350
Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>

 eclass/cmake.eclass | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
index 083b566d26..59835b50f4 100644
--- a/eclass/cmake.eclass
+++ b/eclass/cmake.eclass
@@ -362,6 +362,17 @@ cmake_src_configure() {
        # Fix xdg collision with sandbox
        xdg_environment_reset
 
+       local file ver cmreq_isold
+       while read -d '' -r file ; do
+               ver=$(sed -ne "/cmake_minimum_required/ 
s/.*\(\.\.\.\|\s\)\([0-9.]*\)\([)]\|\s\).*$/\2/p" \
+                       "${file}" 2>/dev/null \
+               )
+
+               if [[ -n $ver ]] && ver_test $ver -lt "3.5"; then
+                       cmreq_isold=true
+               fi
+       done < <(find "${CMAKE_USE_DIR}" -type f -iname "CMakeLists.txt" 
-print0)
+
        # Prepare Gentoo override rules (set valid compiler, append CPPFLAGS 
etc.)
        local build_rules=${BUILD_DIR}/gentoo_rules.cmake
 
@@ -543,6 +554,13 @@ cmake_src_configure() {
                cmakeargs+=( -C "${CMAKE_EXTRA_CACHE_FILE}" )
        fi
 
+       if [[ ${cmreq_isold} ]]; then
+               eqawarn "QA Notice: Compatibility with CMake < 3.5 has been 
removed from CMake 4,"
+               eqawarn "${CATEGORY}/${PN} will fail to build w/o a fix."
+               eqawarn "See also tracker bug #951350; check existing bug or 
file a new one for"
+               eqawarn "this package."
+       fi
+
        pushd "${BUILD_DIR}" > /dev/null || die
        debug-print "${LINENO} ${ECLASS} ${FUNCNAME}: mycmakeargs is 
${mycmakeargs_local[*]}"
        echo "${CMAKE_BINARY}" "${cmakeargs[@]}" "${CMAKE_USE_DIR}"