commit: c176f2c3faa1b5c28e164504025d262655ab8421
Author: Brian Harring <ferringb <AT> gmail <DOT> com>
AuthorDate: Wed Jan 21 18:22:42 2026 +0000
Commit: Brian Harring <ferringb <AT> gmail <DOT> com>
CommitDate: Wed Jan 21 18:30:27 2026 +0000
URL:
https://gitweb.gentoo.org/proj/pkgcore/snakeoil.git/commit/?id=c176f2c3
cleanup where 'is' should have been used.
The tests are explicitly asserting "it's true" or "it's false";
thus use 'is', not '=='.
It also shuts ruff up.
Signed-off-by: Brian Harring <ferringb <AT> gmail.com>
src/snakeoil/osutils/__init__.py | 2 +-
tests/cli/test_input.py | 8 ++++----
tests/test_caching.py | 2 +-
tests/test_mappings.py | 18 +++++++++---------
4 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/snakeoil/osutils/__init__.py b/src/snakeoil/osutils/__init__.py
index cd7cec4..f768808 100644
--- a/src/snakeoil/osutils/__init__.py
+++ b/src/snakeoil/osutils/__init__.py
@@ -48,7 +48,7 @@ def supported_systems(*systems):
... return True
>>>
>>> if sys.platform.startswith(('linux', 'darwin')):
- >>> assert func() == True
+ >>> assert func() is True
``NotImplementedError`` is raised on platforms that aren't supported.
diff --git a/tests/cli/test_input.py b/tests/cli/test_input.py
index 1d19789..92bdb6f 100644
--- a/tests/cli/test_input.py
+++ b/tests/cli/test_input.py
@@ -23,12 +23,12 @@ class TestUserQuery:
def test_default_answer(self, mocked_input):
mocked_input.return_value = ""
- assert self.query("foo") == True
+ assert self.query("foo") is True
def test_tuple_prompt(self, mocked_input):
mocked_input.return_value = ""
prompt = "perhaps a tuple"
- assert self.query(tuple(prompt.split())) == True
+ assert self.query(tuple(prompt.split())) is True
output = "".join(prompt.split())
assert (
self.out.get_text_stream().strip().split("\n")[0][: len(output)]
== output
@@ -41,7 +41,7 @@ class TestUserQuery:
}
# no default answer returns None for empty input
mocked_input.return_value = ""
- assert self.query("foo", responses=responses) == None
+ assert self.query("foo", responses=responses) is None
mocked_input.return_value = "a"
assert self.query("foo", responses=responses) == "z"
mocked_input.return_value = "b"
@@ -80,7 +80,7 @@ class TestUserQuery:
def test_custom_default_answer(self, mocked_input):
mocked_input.return_value = ""
- assert self.query("foo", default_answer=False) == False
+ assert self.query("foo", default_answer=False) is False
def test_eof_nochoice(self, mocked_input):
# user hits ctrl-d
diff --git a/tests/test_caching.py b/tests/test_caching.py
index 95bdc57..1f454de 100644
--- a/tests/test_caching.py
+++ b/tests/test_caching.py
@@ -184,7 +184,7 @@ class TestWeakInstMeta:
new_call = c.__class__.__call__
# ensure it's not mutating the reference functools passes.
assert new_call.__annotations__ is not f.__annotations__
- assert new_call.__annotations__["disable_inst_caching"] == bool
+ assert new_call.__annotations__["disable_inst_caching"] is bool
a = new_call.__annotations__.copy()
a.pop("disable_inst_caching")
assert a == f.__annotations__
diff --git a/tests/test_mappings.py b/tests/test_mappings.py
index d4f1d1a..694a8a9 100644
--- a/tests/test_mappings.py
+++ b/tests/test_mappings.py
@@ -47,8 +47,8 @@ class TestDictMixin:
d = MutableDict(baz="cat")
assert d.setdefault("baz") == "cat"
assert d.setdefault("baz", "foon") == "cat"
- assert d.setdefault("foo") == None
- assert d["foo"] == None
+ assert d.setdefault("foo") is None
+ assert d["foo"] is None
assert d.setdefault("spork", "cat") == "cat"
assert d["spork"] == "cat"
@@ -59,7 +59,7 @@ class TestDictMixin:
assert d.pop("foo") == "bar"
assert d.popitem(), "baz" == "cat"
pytest.raises(KeyError, d.popitem)
- assert d.pop("nonexistent", None) == None
+ assert d.pop("nonexistent", None) is None
def test_init(self):
d = MutableDict((("foo", "bar"), ("spork", "foon")), baz="cat")
@@ -480,17 +480,17 @@ class TestIndeterminantDict:
lambda key: False, starter_dict={}.fromkeys(range(100), True)
)
for x in range(100):
- assert d[x] == True
+ assert d[x] is True
for x in range(100, 110):
- assert d[x] == False
+ assert d[x] is False
def test_behaviour(self):
val = []
d = mappings.IndeterminantDict(
lambda key: val.append(key), {}.fromkeys(range(10), True)
)
- assert d[0] == True
- assert d[11] == None
+ assert d[0] is True
+ assert d[11] is None
assert val == [11]
def func(*a):
@@ -508,9 +508,9 @@ class TestIndeterminantDict:
d = mappings.IndeterminantDict(func, {1: 1})
assert d.get(1, 1) == 1
assert d.get(1, 2) == 1
- assert d.get(2) == None
+ assert d.get(2) is None
assert d.get(2, 2) == 2
- assert d.get(3) == True
+ assert d.get(3) is True
class TestFoldingDict:
