commit:     24779b15daef7101111c12de2dd6a6a5c3e374d4
Author:     Mike Gilbert <floppym <AT> gentoo <DOT> org>
AuthorDate: Sun Sep 27 13:24:49 2015 +0000
Commit:     Brian Dolbec <dolsen <AT> gentoo <DOT> org>
CommitDate: Mon Sep 28 19:07:23 2015 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=24779b15

Revert "unpack: avoid useless chmods to improve speed"

This reverts commit 0dc7b2a3923508896cf217f325b8339d73353553.

The "optimized" chmod is no longer recursive, which causes files to be
missed.

X-Gentoo-Bug: 561368
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=561368

 bin/phase-helpers.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
index b446060..efd2cfa 100644
--- a/bin/phase-helpers.sh
+++ b/bin/phase-helpers.sh
@@ -531,8 +531,8 @@ unpack() {
        done
        # Do not chmod '.' since it's probably ${WORKDIR} and 
PORTAGE_WORKDIR_MODE
        # should be preserved.
-       find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w \
-               -exec chmod -f a+rX,u+w,g-w,o-w '{}' +
+       find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \
+               ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w
 }
 
 econf() {

Reply via email to