commit:     cece35a90acbbf960ee93893038cccb1a36a9c11
Author:     Brian Dolbec <dolsen <AT> gentoo <DOT> org>
AuthorDate: Sun Jan  3 11:31:26 2016 +0000
Commit:     Brian Dolbec <dolsen <AT> gentoo <DOT> org>
CommitDate: Sun Jan 10 20:15:08 2016 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=cece35a9

scanner.py: Migrate another metadata check to ebuild_metadata

 pym/repoman/modules/scan/metadata/ebuild_metadata.py | 3 +++
 pym/repoman/scanner.py                               | 2 --
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/pym/repoman/modules/scan/metadata/ebuild_metadata.py 
b/pym/repoman/modules/scan/metadata/ebuild_metadata.py
index 143a40e..2dc1db2 100644
--- a/pym/repoman/modules/scan/metadata/ebuild_metadata.py
+++ b/pym/repoman/modules/scan/metadata/ebuild_metadata.py
@@ -28,6 +28,9 @@ class EbuildMetadata(object):
                                        "%s: %s variable contains non-ASCII "
                                        "character at position %s" %
                                        (ebuild.relative_path, k, m.start() + 
1))
+               if ebuild.metadata.get("PROVIDE"):
+                       self.qatracker.add_error("virtual.oldstyle", 
ebuild.relative_path)
+
                return {'continue': False}
 
        @property

diff --git a/pym/repoman/scanner.py b/pym/repoman/scanner.py
index e6a17cd..46f46f5 100644
--- a/pym/repoman/scanner.py
+++ b/pym/repoman/scanner.py
@@ -324,8 +324,6 @@ class Scanner(object):
                        if y_ebuild_continue:
                                continue
 
-                       if dynamic_data['ebuild'].metadata.get("PROVIDE"):
-                               self.qatracker.add_error("virtual.oldstyle", 
dynamic_data['ebuild'].relative_path)
 
                        for pos, missing_var in enumerate(missingvars):
                                if not 
dynamic_data['ebuild'].metadata.get(missing_var):

Reply via email to