[gentoo-commits] repo/gentoo:master commit in: eclass/

[Michał Górny]

commit:     2980579f58b803d7c2ba9e6f374fdd5a40cb9339
Author:     Michał Górny <mgorny <AT> gentoo <DOT> org>
AuthorDate: Wed Mar  1 08:14:13 2017 +0000
Commit:     Michał Górny <mgorny <AT> gentoo <DOT> org>
CommitDate: Wed Mar  8 07:35:42 2017 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2980579f

python-utils-r1.eclass: _python_set_impls, use local vars

Refactor _python_set_impls to use local variables throughout
the function and assign global values at the end. This prepares it for
double-inherit integrity checks. NFC.

 eclass/python-utils-r1.eclass | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
index 0cc5b963998..a6f197bd418 100644
--- a/eclass/python-utils-r1.eclass
+++ b/eclass/python-utils-r1.eclass
@@ -114,21 +114,22 @@ _python_set_impls() {
                _python_impl_supported "${i}"
        done
 
-       _PYTHON_SUPPORTED_IMPLS=()
-       _PYTHON_UNSUPPORTED_IMPLS=()
+       local supp=() unsupp=()
 
        for i in "${_PYTHON_ALL_IMPLS[@]}"; do
                if has "${i}" "${PYTHON_COMPAT[@]}"; then
-                       _PYTHON_SUPPORTED_IMPLS+=( "${i}" )
+                       supp+=( "${i}" )
                else
-                       _PYTHON_UNSUPPORTED_IMPLS+=( "${i}" )
+                       unsupp+=( "${i}" )
                fi
        done
 
-       if [[ ${#_PYTHON_SUPPORTED_IMPLS[@]} -eq 0 ]]; then
+       if [[ ! ${supp[@]} ]]; then
                die "No supported implementation in PYTHON_COMPAT."
        fi
 
+       _PYTHON_SUPPORTED_IMPLS=( "${supp[@]}" )
+       _PYTHON_UNSUPPORTED_IMPLS=( "${unsupp[@]}" )
        readonly _PYTHON_SUPPORTED_IMPLS _PYTHON_UNSUPPORTED_IMPLS
 }