commit:     da9b5185640ac15d930624e1d52621c8a3da87f2
Author:     Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
AuthorDate: Sun Nov 19 22:58:48 2017 +0000
Commit:     Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
CommitDate: Sun Nov 19 23:00:15 2017 +0000
URL:        https://gitweb.gentoo.org/proj/crossdev.git/commit/?id=da9b5185

crossdev: remove support for undocumented -b -d -p -v -q -pv -vp options, bug 
#638182

In bug #638182 Maciej tried to use crossdev as:
    crossdev -t x86_64-w64-mingw32 -b 2.28.1
which attempted to build configs for '2.28.1' target.

crossdev silently passed '-b' to emerge and treated
next argument as target option.

This change removes all undocumented options.
Use '-P <option>' instead.

That way typo is reported correctly as:
    * UNKNOWN OPTION: '-b'

Bug: https://bugs.gentoo.org/638182
Signed-off-by: Sergei Trofimovich <slyfox <AT> gentoo.org>

 crossdev | 2 --
 1 file changed, 2 deletions(-)

diff --git a/crossdev b/crossdev
index 0eaa721..3a3fdf5 100755
--- a/crossdev
+++ b/crossdev
@@ -652,8 +652,6 @@ while [[ $# -gt 0 ]] ; do
        --show-fail-log)   SHOW_FAIL_LOG="yes";;
        --show-repo-cfg)   show_repo_cfg "$2";;
        -P|--portage)      UOPTS="${UOPTS} $2"; shift;;
-       -b|-d|-p|-v|-q)    UOPTS="${UOPTS} $1";;
-       -pv|-vp)           UOPTS="${UOPTS} -p -v";;
        -h|--help)         usage;;
        -*)                eerror "UNKNOWN OPTION: '$1'" ; usage 1;;
        *)                 parse_target $1;;

Reply via email to