commit:     d3778a92be0ac4a22eb61e3affdc85f99337847a
Author:     Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Wed Feb 21 23:14:44 2018 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Thu Feb 22 17:30:26 2018 +0000

portage.process.spawn: default close_fds=False (bug 648432)

For python3.4 and later, default to close_fds=False, since file
descriptors are non-inheritable by default due to PEP 446. This solves
a performance problem on systems like FreeBSD, where our get_open_fds
function returns all possible file descriptor values (including those
that are not open).


 pym/portage/ | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/pym/portage/ b/pym/portage/
index bc4efb5fe..4d96f156e 100644
--- a/pym/portage/
+++ b/pym/portage/
@@ -196,7 +196,8 @@ def cleanup():
 def spawn(mycommand, env={}, opt_name=None, fd_pipes=None, returnpid=False,
           uid=None, gid=None, groups=None, umask=None, logfile=None,
-          path_lookup=True, pre_exec=None, close_fds=True, unshare_net=False,
+          path_lookup=True, pre_exec=None,
+          close_fds=(sys.version_info < (3, 4)), unshare_net=False,
           unshare_ipc=False, cgroup=None):
        Spawns a given command.
@@ -228,7 +229,8 @@ def spawn(mycommand, env={}, opt_name=None, fd_pipes=None, 
        @param pre_exec: A function to be called with no arguments just prior 
to the exec call.
        @type pre_exec: callable
        @param close_fds: If True, then close all file descriptors except those
-               referenced by fd_pipes (default is True).
+               referenced by fd_pipes (default is True for python3.3 and 
earlier, and False for
+               python3.4 and later due to non-inheritable file descriptor 
behavior from PEP 446).
        @type close_fds: Boolean
        @param unshare_net: If True, networking will be unshared from the 
spawned process
        @type unshare_net: Boolean

Reply via email to