commit:     5fc7da2079b2e04b5a0dd66e57ff9545ab54069d
Author:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
AuthorDate: Thu Apr  5 13:27:30 2018 +0000
Commit:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Thu Apr  5 13:27:30 2018 +0000
URL:        https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=5fc7da20

tests/atom_compare/Makefile: fail when there are differences

The static tests fell off the radar because actual differences did not
result in failure (e.g. Travis being green and all), also the sed magic
was too loose, causing a wrong input file to be computed

 tests/atom_compare/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/atom_compare/Makefile b/tests/atom_compare/Makefile
index 71a980f..ead9d75 100644
--- a/tests/atom_compare/Makefile
+++ b/tests/atom_compare/Makefile
@@ -8,7 +8,7 @@ test check: static static.q portage
 t = \
        @set -f && \
        $(call mkdir,$(b)) && \
-       good=`echo $< | sed 's:.tests:.good:'`; \
+       good=`echo $< | sed 's:.tests$$:.good:'`; \
        out=$(@:.tests=); \
        ret=0; \
        $(realpath $(lastword $^)) $(1) `sed 's:\#.*::' $<` > $$out || ret=$$?; 
\
@@ -18,6 +18,7 @@ t = \
                        echo "PASS atom_compare $$out"; \
                else \
                        echo "FAIL atom_compare $$out"; \
+                       ret=1; \
                fi;; \
        77) echo "SKIP atom_compare $$out"; ret=0;; \
        *) echo "FAIL atom_compare $$out";; \

Reply via email to