commit:     de6b2ac12e02c690f8dee2517af1c09b436f5fc9
Author:     Hanno Boeck <hanno <AT> gentoo <DOT> org>
AuthorDate: Wed Jul 18 20:03:34 2018 +0000
Commit:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Wed Jul 18 20:03:34 2018 +0000
URL:        https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=de6b2ac1

main: fix potential buffer underrun

Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>

 main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/main.c b/main.c
index 7dbdbe7..30dd063 100644
--- a/main.c
+++ b/main.c
@@ -969,7 +969,7 @@ initialize_portage_env(void)
 
        /* Make sure ROOT always ends in a slash */
        var = &vars_to_read[0];
-       if ((*var->value.s)[var->value_len - 1] != '/') {
+       if (var->value_len == 0 || (*var->value.s)[var->value_len - 1] != '/') {
                portroot = xrealloc(portroot, var->value_len + 2);
                portroot[var->value_len] = '/';
                portroot[var->value_len + 1] = '\0';

Reply via email to