commit: 49add11ae54e82cc38e51b2aaf22e06fedecb918 Author: Michał Górny <mgorny <AT> gentoo <DOT> org> AuthorDate: Sun Nov 3 07:52:07 2019 +0000 Commit: Göktürk Yüksek <gokturk <AT> gentoo <DOT> org> CommitDate: Tue Nov 26 01:48:46 2019 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=49add11a
ebuild-writing/variables: explicitly discourage HOMEPAGE in SRC_URI Closes: https://github.com/gentoo/devmanual/pull/115 Signed-off-by: Michał Górny <mgorny <AT> gentoo.org> Signed-off-by: Göktürk Yüksek <gokturk <AT> gentoo.org> ebuild-writing/variables/text.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ebuild-writing/variables/text.xml b/ebuild-writing/variables/text.xml index 8854a3a..35dc8f2 100644 --- a/ebuild-writing/variables/text.xml +++ b/ebuild-writing/variables/text.xml @@ -699,6 +699,11 @@ have no direct correlation with the expected string should be avoided. (e.g. while reviewing via gitweb), </li> + <li> + using <c>${HOMEPAGE}</c> in <c>SRC_URI</c> — it breaks when homepage + changes or additional entry is added, + </li> + <li> using <c>${PN}</c> (or other unnecessary helper variables) excessively in <c>src_install()</c> — it impairs readability for