commit: 981f0a47acc281bcfec4faa966d0bfb447b28ddd
Author: Fabian Groffen <grobian <AT> gentoo <DOT> org>
AuthorDate: Mon Jan 20 19:53:47 2020 +0000
Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Mon Jan 20 19:53:47 2020 +0000
URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=981f0a47
libq/colors: fix Coverity 183476 Buffer not null terminated
Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>
libq/colors.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libq/colors.c b/libq/colors.c
index 88664c3..9a48e2e 100644
--- a/libq/colors.c
+++ b/libq/colors.c
@@ -102,8 +102,9 @@ color_remap(void)
int found = 0;
for (n = 0; n <
ARRAY_SIZE(color_pairs); n++) {
if (strcmp(color_pairs[n].name,
p) == 0) {
-
strncpy(color_pairs[i].value,
-
color_pairs[n].origval, CPAIR_VALUE_LEN);
+
snprintf(color_pairs[i].value,
+
sizeof(color_pairs[i].value),
+ "%s",
color_pairs[n].origval);
found = 1;
break;
}
@@ -111,7 +112,7 @@ color_remap(void)
if (!found)
snprintf(color_pairs[i].value,
-
sizeof(color_pairs[i].origval), "\e[%s", p);
+
sizeof(color_pairs[i].value), "\e[%s", p);
}
}
}