[gentoo-commits] proj/portage-utils:master commit in: /

[Fabian Groffen]

commit:     029cf600be9203e944180bcd0fd4da714052457c
Author:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
AuthorDate: Fri Jan 31 13:08:59 2020 +0000
Commit:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Fri Jan 31 13:08:59 2020 +0000
URL:        https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=029cf600

qmerge: fix Coverity 207952 Resource leak

Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>

 qmerge.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/qmerge.c b/qmerge.c
index fc20f10..5eec188 100644
--- a/qmerge.c
+++ b/qmerge.c
@@ -1604,14 +1604,15 @@ unlink_empty(const char *buf)
 {
        struct stat st;
        int fd;
+       int ret = -1;
 
        fd = open(buf, O_RDONLY);
        if (fd != -1 && stat(buf, &st) != -1) {
                if (st.st_size == 0)
-                       return unlink(buf);
+                       ret = unlink(buf);
                close(fd);
        }
-       return -1;
+       return ret;
 }
 
 static int