commit: e3eec598ad72c292bca9a1c5d23f0e5989bc78b3 Author: Alexander Berntsen <bernalex <AT> gentoo <DOT> org> AuthorDate: Tue Aug 12 18:53:52 2014 +0000 Commit: Alexander Berntsen <bernalex <AT> gentoo <DOT> org> CommitDate: Tue Aug 12 21:54:31 2014 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=e3eec598
Note the use of X-by in DEVELOPING Signed-off-by: Alexander Berntsen <bernalex <AT> gentoo.org> Reviewed-by: Brian Dolbec <dolsen <AT> gentoo.org> --- DEVELOPING | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/DEVELOPING b/DEVELOPING index 0ffcbd7..b1b3390 100644 --- a/DEVELOPING +++ b/DEVELOPING @@ -181,7 +181,18 @@ Commit messages should be in the imperative mood with a capitalised header, optionally followed by a newline and a more detailed explanatory text. The headline should be capped at 70 characters, the detailed text at 72. Prefix the message with the component you touched if this makes -sense. Postfix the message with the bug it fixes, if it does. Example: +sense. Postfix the message with the bug it fixes, if it does. + +Feel free to use the following notes (if applicable): +Signed-off-by: Wrote (a substantial portion of) the patch +Reviewed-by: Reviewed the patch thoroughly +Tested-by: Tested the patch thoroughly +Acked-by: Approved the concept but did not read the patch in detail +(typically used by the maintainer of a specific portion, or a lead) +Suggested-by: Designed the implementation +Reported-by: Reported the bug/feature request + +Example: " emerge: Fix --tree output (bug 555555) @@ -189,6 +200,10 @@ emerge: Fix --tree output (bug 555555) Make sure newlines appear where they are supposed to. Fix a bug with colourisation of --tree output when used in tandem with --verbose --pretend --ask. + +Signed-off-by: Foo Bar <[email protected]> +Reviewed-by: Fu Baz <[email protected]> +Reported-by: Qux Quux <[email protected]> " For a more detailed explanation (and rationalisation) of these rules:
