commit:     b5aba660b59271a21f9a0104680cee3472e8eebd
Author:     Alexander Berntsen <bernalex <AT> gentoo <DOT> org>
AuthorDate: Tue Aug 12 21:18:35 2014 +0000
Commit:     Alexander Berntsen <bernalex <AT> gentoo <DOT> org>
CommitDate: Tue Aug 12 21:54:31 2014 +0000
URL:        
http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=b5aba660

repoman: Disable DESCRIPTION.punctuation check

This reverts commits:
  06637c4215d55c57517739214c6e0fd6f8f53914
  repoman: Add DESCRIPTION.puntuation check (bug #438976)

  0a2dab393f2ecf0476262620aa2e9a68d1f88a95
  repoman: Add accidently deleted closing bracket ')'

  bbb34efebd0bfc0b231073d00b863b3e3ebd918a
  repoman: Do not report DESCRIPTION.punctuation warning for "etc.".

QA has requested these reverts, as they did not approve of this repoman
check.

Signed-off-by: Alexander Berntsen <bernalex <AT> gentoo.org>
Reviewed-by:   Brian Dolbec       <dolsen <AT> gentoo.org>

---
 RELEASE-NOTES |  5 +++++
 bin/repoman   | 12 ------------
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 9b4cbb7..22770ef 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -1,6 +1,11 @@
 Release Notes; upgrade information mainly.
 Features/major bugfixes are listed in NEWS
 
+portage-2.2.13
+==================================
+* Bug Fixes:
+    - Bug # 438976 Remove DESCRIPTION.punctuation check from repoman
+
 portage-2.2.12
 ==================================
 * Bug Fixes:

diff --git a/bin/repoman b/bin/repoman
index bd9ad15..5a6ee5b 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -319,7 +319,6 @@ qahelp = {
        "LICENSE.missing": "Ebuilds that have a missing or empty LICENSE 
variable",
        "LICENSE.virtual": "Virtuals that have a non-empty LICENSE variable",
        "DESCRIPTION.missing": "Ebuilds that have a missing or empty 
DESCRIPTION variable",
-       "DESCRIPTION.punctuation": "DESCRIPTION ends with a period character",
        "DESCRIPTION.toolong": "DESCRIPTION is over %d characters" % 
max_desc_len,
        "EAPI.definition": "EAPI definition does not conform to PMS section 
7.3.1 (first non-comment, non-blank line)",
        "EAPI.deprecated": "Ebuilds that use features that are deprecated in 
the current EAPI",
@@ -388,7 +387,6 @@ qawarnings = set((
 "dependency.badmaskedindev",
 "dependency.badtilde",
 "dependency.perlcore",
-"DESCRIPTION.punctuation",
 "DESCRIPTION.toolong",
 "EAPI.deprecated",
 "HOMEPAGE.virtual",
@@ -1895,16 +1893,6 @@ for x in effective_scanlist:
                                        stats[myqakey] += 1
                                        fails[myqakey].append(relative_path)
 
-               # Abbreviations usable at the end of sentence.
-               abbreviations = (
-                       'etc.',
-               )
-               if myaux['DESCRIPTION'][-1:] == '.' and not 
myaux['DESCRIPTION'].split()[-1] in abbreviations:
-                       stats['DESCRIPTION.punctuation'] += 1
-                       fails['DESCRIPTION.punctuation'].append(
-                               "%s: DESCRIPTION ends with a '%s' character"
-                               % (relative_path, myaux['DESCRIPTION'][-1:]))
-
                # 14 is the length of DESCRIPTION=""
                if len(myaux['DESCRIPTION']) > max_desc_len:
                        stats['DESCRIPTION.toolong'] += 1

Reply via email to