commit:     2c94ad560187ec2a882d9d5805a396e0919e93de
Author:     Marek Szuba <marecki <AT> gentoo <DOT> org>
AuthorDate: Fri Apr 24 14:22:56 2020 +0000
Commit:     Marek Szuba <marecki <AT> gentoo <DOT> org>
CommitDate: Fri Apr 24 14:25:42 2020 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c94ad56

sys-cluster/singularity: do not install bash-completion rules

Singularity installs them into the compatibility directory
(/etc/bash_completions.d), moreover they might be automatically generated
but they are still badly broken (confirmed to affect quite a few
commands which have got nothing to do with singularity).

With apologies to everyone who will end up emerge a revbump just to get
rid of a single shell file.

Signed-off-by: Marek Szuba <marecki <AT> gentoo.org>

 .../{singularity-3.5.3.ebuild => singularity-3.5.3-r1.ebuild}  | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sys-cluster/singularity/singularity-3.5.3.ebuild 
b/sys-cluster/singularity/singularity-3.5.3-r1.ebuild
similarity index 69%
rename from sys-cluster/singularity/singularity-3.5.3.ebuild
rename to sys-cluster/singularity/singularity-3.5.3-r1.ebuild
index 2a51a4074fc..16834ae083a 100644
--- a/sys-cluster/singularity/singularity-3.5.3.ebuild
+++ b/sys-cluster/singularity/singularity-3.5.3-r1.ebuild
@@ -52,6 +52,16 @@ src_install() {
        emake DESTDIR="${ED}" -C builddir install
        keepdir /var/singularity/mnt/session
 
+       # As of version 3.5.3 this seems to be very much broken, affecting
+       # commands which have got nothing to do with singularity (example:
+       # completion on 'udisks mount -b /dev/' rejects all files from that
+       # directory other than 'autofs'). Moreover, this should go into
+       # $(get_bashcompdir) (from bash-completion-r1.eclass) rather than /etc.
+       # Hopefully temporary, which is why we delete this at install time
+       # instead of patching build scripts not to generate bash-completion
+       # data in the first place.
+       rm -rf "${ED}"/etc/bash_completion.d || die
+
        dodoc README.md CONTRIBUTORS.md CONTRIBUTING.md
        if use examples; then
                dodoc -r examples

Reply via email to