commit:     3aa8c1ccb012b519014b4f5f444e58554fb9dfaa
Author:     David Seifert <soap <AT> gentoo <DOT> org>
AuthorDate: Thu Jun 11 13:49:06 2020 +0000
Commit:     David Seifert <soap <AT> gentoo <DOT> org>
CommitDate: Thu Jun 11 13:49:06 2020 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3aa8c1cc

net-fs/netatalk: [QA] clean up ebuild

* remove static archives/.la files
* remove USE=static-libs
* use ${ED} consistently
* don't mix output streams

Package-Manager: Portage-2.3.100, Repoman-2.3.22
Signed-off-by: David Seifert <soap <AT> gentoo.org>

 net-fs/netatalk/netatalk-3.1.12.ebuild | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/net-fs/netatalk/netatalk-3.1.12.ebuild 
b/net-fs/netatalk/netatalk-3.1.12.ebuild
index 89d0bf17760..c56257545e1 100644
--- a/net-fs/netatalk/netatalk-3.1.12.ebuild
+++ b/net-fs/netatalk/netatalk-3.1.12.ebuild
@@ -16,7 +16,7 @@ SRC_URI="mirror://sourceforge/project/${PN}/${PN}/$(ver_cut 
1-3)/${P}.tar.bz2"
 LICENSE="GPL-2 BSD"
 SLOT="0/18.0"
 KEYWORDS="amd64 arm ~ppc ~ppc64 x86"
-IUSE="acl cracklib dbus debug kerberos ldap pam pgp quota samba +shadow ssl 
static-libs tracker tcpd +utils zeroconf"
+IUSE="acl cracklib dbus debug kerberos ldap pam pgp quota samba +shadow ssl 
tracker tcpd +utils zeroconf"
 
 CDEPEND="
        !app-editors/yudit
@@ -102,6 +102,7 @@ src_configure() {
                $(use_with tracker)
                $(use_with tracker dbus-daemon "${EPREFIX}/usr/bin/dbus-daemon")
                $(use_with tracker tracker-pkgconfig-version $(ver_cut 1 
$(best_version app-misc/tracker | sed 's:app-misc/tracker-::g')).0)
+               --disable-static
                --enable-overwrite
                --disable-krb4-uam
                --disable-afs
@@ -121,9 +122,9 @@ src_install() {
        default
 
        if use zeroconf; then
-               sed -i -e '/avahi-daemon/s:use:need:g' "${D}"/etc/init.d/${PN} 
|| die
+               sed -i -e '/avahi-daemon/s:use:need:g' "${ED}"/etc/init.d/${PN} 
|| die
        else
-               sed -i -e '/avahi-daemon/d' "${D}"/etc/init.d/${PN} || die
+               sed -i -e '/avahi-daemon/d' "${ED}"/etc/init.d/${PN} || die
        fi
 
        # The pamd file isn't what we need, use pamd_mimic_system
@@ -138,6 +139,9 @@ src_install() {
        systemd_newunit "${T}"/service.systemd ${PN}.service
 
        use utils && python_foreach_impl python_doscript 
contrib/shell_utils/afpstats
+
+       # no static archives
+       find "${ED}" -name '*.la' -delete || die
 }
 
 pkg_postinst() {
@@ -154,29 +158,29 @@ pkg_postinst() {
                                fi
                        done
 
-                       echo ""
+                       elog
                        elog "Starting from version 3.0 only uses a single init 
script again"
                        elog "Please update your runlevels accordingly"
-                       echo ""
+                       elog
                        elog "Dependencies should be resolved automatically 
depending on settings"
                        elog "but please report issues with this on 
https://bugs.gentoo.org/ if"
                        elog "you find any."
-                       echo ""
+                       elog
                        elog "Following config files are obsolete now:"
                        elog "afpd.conf, netatalk.conf, AppleVolumes.default 
and afp_ldap.conf"
                        elog "in favour of"
                        elog "/etc/afp.conf"
-                       echo ""
+                       elog
                        elog "Please convert your existing configs before you 
restart your daemon"
-                       echo ""
+                       elog
                        elog "The new AppleDouble default backend is 
appledouble = ea"
                        elog "Existing entries will be updated on access, but 
can do an offline"
                        elog "conversion with"
                        elog "dbd -ruve /path/to/Volume"
-                       echo ""
+                       elog
                        elog "For general notes on the upgrade, please visit"
                        elog 
"http://netatalk.sourceforge.net/3.0/htmldocs/upgrade.html";
-                       echo ""
+                       elog
                        break
                fi
        done

Reply via email to