commit:     2e1834613e434ec0700d888a7c63bf53da39903b
Author:     Marek Szuba <marecki <AT> gentoo <DOT> org>
AuthorDate: Tue Dec  1 22:39:04 2020 +0000
Commit:     Marek Szuba <marecki <AT> gentoo <DOT> org>
CommitDate: Tue Dec  1 22:53:53 2020 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e183461

games-strategy/naev-0.7.0: fix SRC_URI, explain BDEPEND/src_unpack

pkgcheck complains about the lack of app-arch/unzip in BDEPEND but
that is not correct - the data file is supposed to be installed zipped,
and the custom src_unpack ensures only the source tarball is actually
unpacked. Add a comment explaining this.

More importantly, both SRC_URI wrong had '/${P}/' where '/v${PV}/' should
be according to the layout of GitHub upstream as of 5 minutes ago.

Signed-off-by: Marek Szuba <marecki <AT> gentoo.org>

 games-strategy/naev/naev-0.7.0.ebuild | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/games-strategy/naev/naev-0.7.0.ebuild 
b/games-strategy/naev/naev-0.7.0.ebuild
index 20d6fd69fb5..1b20e968fdd 100644
--- a/games-strategy/naev/naev-0.7.0.ebuild
+++ b/games-strategy/naev/naev-0.7.0.ebuild
@@ -2,12 +2,13 @@
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
+
 inherit xdg-utils
 
 DESCRIPTION="A 2D space trading and combat game, in a similar vein to Escape 
Velocity"
 HOMEPAGE="https://naev.org/ https://github.com/naev/naev";
-SRC_URI="https://github.com/naev/naev/releases/download/${P}/${P}.tar.bz2
-       https://github.com/naev/naev/releases/download/${P}/${P}-ndata.zip";
+SRC_URI="https://github.com/naev/naev/releases/download/v${PV}/${P}.tar.bz2
+       https://github.com/naev/naev/releases/download/v${PV}/${P}-ndata.zip";
 
 LICENSE="GPL-2 GPL-3 public-domain CC-BY-3.0 CC-BY-SA-3.0"
 SLOT="0"
@@ -30,6 +31,9 @@ RDEPEND="
 DEPEND="${RDEPEND}"
 BDEPEND="virtual/pkgconfig"
 
+# This is so that only the source tarball is unpacked - the data file
+# is supposed to be installed *zipped*. This is why we do not need unzip
+# in BDEPEND in spite of what repoman/pkgcheck might say.
 src_unpack() {
        unpack ${P}.tar.bz2
 }

Reply via email to