commit: e57ed600e070e5cbfbd57086f7497cfd8ca480d9 Author: Patrice Clement <monsieurp <AT> gentoo <DOT> org> AuthorDate: Tue Nov 4 14:42:47 2014 +0000 Commit: Christian Ruppert <idl0r <AT> gentoo <DOT> org> CommitDate: Sat Nov 8 17:48:03 2014 +0000 URL: http://sources.gentoo.org/gitweb/?p=proj/gentoolkit.git;a=commit;h=e57ed600
echangelog: get rid of useless hash calls down to only one --- src/echangelog/echangelog | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/echangelog/echangelog b/src/echangelog/echangelog index 7f5e307..adf3ac8 100755 --- a/src/echangelog/echangelog +++ b/src/echangelog/echangelog @@ -108,17 +108,19 @@ sub version { exit 0; } -sub getenv($) { +sub getenv ($) { my $key = shift; - # Ensure our variable exist - if ( defined($ENV{$key}) ) { - # Ensure we don't get empty variables - if ( length($ENV{$key}) > 0 ) { - return $ENV{$key}; - } - } - return; + # Check for key: defined and not empty + return if !$key or $key eq ''; + + # Fetch key in %ENV hash + my $env = $ENV{$key}; + + # Make sure the variable does exist, + # check for its length + # and return it + return $env if $env and (length($env) > 0); } # Bug 264146.