commit: 8e997a3231771c98aebfdd4bc66617edc044dfdd Author: Mike Pagano <mpagano <AT> gentoo <DOT> org> AuthorDate: Tue Apr 26 12:17:16 2022 +0000 Commit: Mike Pagano <mpagano <AT> gentoo <DOT> org> CommitDate: Tue Apr 26 12:17:16 2022 +0000 URL: https://gitweb.gentoo.org/proj/linux-patches.git/commit/?id=8e997a32
gpio: Request interrupts after IRQ is initialized Bug: https://bugs.gentoo.org/840942 Signed-off-by: Mike Pagano <mpagano <AT> gentoo.org> 0000_README | 4 ++ ...quest-interrupts-after-IRQ-is-initialized.patch | 75 ++++++++++++++++++++++ 2 files changed, 79 insertions(+) diff --git a/0000_README b/0000_README index a85d4035..79bdf239 100644 --- a/0000_README +++ b/0000_README @@ -503,6 +503,10 @@ Patch: 2000_BT-Check-key-sizes-only-if-Secure-Simple-Pairing-enabled.patch From: https://lore.kernel.org/linux-bluetooth/[email protected]/raw Desc: Bluetooth: Check key sizes only when Secure Simple Pairing is enabled. See bug #686758 +Path: 2800_gpio-Request-interrupts-after-IRQ-is-initialized.patch +From: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch/drivers/gpio?id=06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 +Desc: gpio: Request interrupts after IRQ is initialized + Patch: 2900_tmp513-Fix-build-issue-by-selecting-CONFIG_REG.patch From: https://bugs.gentoo.org/710790 Desc: tmp513 requies REGMAP_I2C to build. Select it by default in Kconfig. See bug #710790. Thanks to Phil Stracchino diff --git a/2800_gpio-Request-interrupts-after-IRQ-is-initialized.patch b/2800_gpio-Request-interrupts-after-IRQ-is-initialized.patch new file mode 100644 index 00000000..0a1d4624 --- /dev/null +++ b/2800_gpio-Request-interrupts-after-IRQ-is-initialized.patch @@ -0,0 +1,75 @@ +From 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 Mon Sep 17 00:00:00 2001 +From: Mario Limonciello <[email protected]> +Date: Fri, 22 Apr 2022 08:14:52 -0500 +Subject: gpio: Request interrupts after IRQ is initialized +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Commit 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members +before initialization") attempted to fix a race condition that lead to a +NULL pointer, but in the process caused a regression for _AEI/_EVT +declared GPIOs. + +This manifests in messages showing deferred probing while trying to +allocate IRQs like so: + + amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x0000 to IRQ, err -517 + amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x002C to IRQ, err -517 + amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517 + [ .. more of the same .. ] + +The code for walking _AEI doesn't handle deferred probing and so this +leads to non-functional GPIO interrupts. + +Fix this issue by moving the call to `acpi_gpiochip_request_interrupts` +to occur after gc->irc.initialized is set. + +Fixes: 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members before initialization") +Link: https://lore.kernel.org/linux-gpio/bl1pr12mb51577a77f000a008aa694675e2...@bl1pr12mb5157.namprd12.prod.outlook.com/ +Link: https://bugzilla.suse.com/show_bug.cgi?id=1198697 +Link: https://bugzilla.kernel.org/show_bug.cgi?id=215850 +Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1979 +Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1976 +Reported-by: Mario Limonciello <[email protected]> +Signed-off-by: Mario Limonciello <[email protected]> +Reviewed-by: Shreeya Patel <[email protected]> +Tested-By: Samuel Čavoj <[email protected]> +Tested-By: [email protected] Link: +Reviewed-by: Andy Shevchenko <[email protected]> +Acked-by: Linus Walleij <[email protected]> +Reviewed-and-tested-by: Takashi Iwai <[email protected]> +Cc: Shreeya Patel <[email protected]> +Cc: [email protected] +Signed-off-by: Linus Torvalds <[email protected]> +--- + drivers/gpio/gpiolib.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +(limited to 'drivers/gpio') + +diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c +index 085348e089860..b7694171655cf 100644 +--- a/drivers/gpio/gpiolib.c ++++ b/drivers/gpio/gpiolib.c +@@ -1601,8 +1601,6 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc, + + gpiochip_set_irq_hooks(gc); + +- acpi_gpiochip_request_interrupts(gc); +- + /* + * Using barrier() here to prevent compiler from reordering + * gc->irq.initialized before initialization of above +@@ -1612,6 +1610,8 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc, + + gc->irq.initialized = true; + ++ acpi_gpiochip_request_interrupts(gc); ++ + return 0; + } + +-- +cgit 1.2.3-1.el7 +
