commit: f5cec0886bed97956d047c73cb997f2aa2a15b5f Author: Sam James <sam <AT> gentoo <DOT> org> AuthorDate: Fri Aug 26 04:42:02 2022 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Sat Jan 14 20:04:05 2023 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=f5cec088
general-concepts/ebuild-revisions: clarify interaction with adding/removing USE flags Note that when adding a USE flag where the functionality was previously on (not off in build system), one must revbump because a dep was unconditional that now became conditional. Also, if removing a USE flag where the behaviour is now on, but was previously always off (not on in build system), one must revbump also, because people might have never set USE=foo (hence --changed-use wouldn't pick it up) but their deps have now effectively changed. Bug: https://github.com/pkgcore/pkgcheck/pull/435 Signed-off-by: Sam James <sam <AT> gentoo.org> general-concepts/ebuild-revisions/text.xml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index ad394e8..e0c8b01 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -103,8 +103,14 @@ of thumb could be used as a guideline: (unless it is also a runtime dependency), </li> <li> - adding a new USE flag or removing an existing one (since change - in USE flags is going to trigger <c>--changed-use</c> rebuild), + adding a new USE flag if it controls a USE-dependency where the + functionality was hard-disabled in the build system before, + </li> + <li> + removing an existing USE flag if it controls a USE-dependency where the + functionality is now disabled entirely, rather than always being enabled + (since the change in USE flags is going to trigger a <c>--changed-use</c> + rebuild), </li> <li> a trivial stylistic / ebuild code change (as long as the new code
