commit:     c7d99dc38a647899e8dad2e036439ecf4b1fdf2b
Author:     Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Wed Feb 15 06:27:54 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Feb 15 07:32:40 2023 +0000
URL:        
https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=c7d99dc3

Don't use %b to format the "[ ok ]" and "[ !! ]" strings in _eend()

The success/failure strings were once injected into format strings. The
effect of doing so does not need to be mimicked because, even where
_eend() incororates ECMA-48 sequences, they are always in a raw form and
do not require decoding.

Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 functions.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/functions.sh b/functions.sh
index 4f94ab0..151775f 100644
--- a/functions.sh
+++ b/functions.sh
@@ -229,10 +229,10 @@ _eend()
        fi
 
        if [ -n "${genfun_endcol}" ]; then
-               printf '%s  %b\n' "${genfun_endcol}" "${msg}"
+               printf '%s  %s\n' "${genfun_endcol}" "${msg}"
        else
                [ "${genfun_lastcall}" = ebegin ] || genfun_lastbegun_strlen=0
-               printf "%$(( genfun_cols - genfun_lastbegun_strlen - 6 ))s%b\n" 
'' "${msg}"
+               printf "%$(( genfun_cols - genfun_lastbegun_strlen - 6 ))s%s\n" 
'' "${msg}"
        fi
 
        return "${retval}"

Reply via email to